Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create inmobi-cohort.md #96

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

Brandoncharleskhoo1
Copy link
Contributor

Amplitude Developer Docs PR

Description

Describe your changes.

Deadline

When do these changes need to be live on the site?

Change type

  • Doc bug fix. Fixes #[insert issue number]. Amplitude contributors include Jira issue number.
  • Doc update.
  • New documentation.
  • Non-documentation related fix or update.

PR checklist:

  • My documentation follows the style guidelines of this project.
  • I previewed my documentation on a local server using mkdocs serve.
  • Running mkdocs serve didn't generate any failures.
  • I have performed a self-review of my own documentation.

@amplitude-dev-docs

Copy link

github-actions bot commented Nov 23, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ MARKDOWN markdownlint 2 0 0.22s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-96.d19s7xzcva2mw3.amplifyapp.com

Copy link
Contributor

@zc632995195 zc632995195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for drafting this Brandon!

Overall LGTM, let us hold off till we work with InMobi for the test sync (and get their confirmation the setup/format looks good).

Also there are some warning from GitHub Actions about word choices -- I think those are checks/best practices applied from tech writter, so can be addressed them before we release :)

1. In Amplitude Data, click **Catalog** and select the **Destinations** tab.
2. In the Cohort section, click **Amazon S3 (Cohorts)**. Don't select **Amazon S3** for this integration.
3. Paste in the details you've obtained from the InMobi team under **Bucket Name**, and **Bucket region**.
4. Enter your **Bucket Path** (which should be your advertiser_id), and enter a **Name** for the destination. The name is used when syncing a cohort from Amplitude.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For **Bucket Path** (which should be your advertiser_id), let us hold on this draft until we work with InMobi people to confirm this.

docs/data/destinations/inmobi-cohort.md Outdated Show resolved Hide resolved
Comment on lines 52 to 53
4. (Optional). Set the following two optional parameters:
- **Routing Key:** Enter a string to be appended to the end of the cohort file name in S3. We recommend using your advertiser_id.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment above, regarding how we pass advertiser_id we can work with InMobi to finalize the format works, then we can update doc.

docs/data/destinations/inmobi-cohort.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants