Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.md #114

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Update index.md #114

wants to merge 5 commits into from

Conversation

zheniasemenina
Copy link
Contributor

Added a note on Start/End Session events to clarify that they do count towards the event volume.

Amplitude Developer Docs PR

Description

Describe your changes.

Deadline

When do these changes need to be live on the site?

Change type

  • Doc bug fix. Fixes #[insert issue number]. Amplitude contributors include Jira issue number.
  • Doc update.
  • New documentation.
  • Non-documentation related fix or update.

PR checklist:

  • My documentation follows the style guidelines of this project.
  • I previewed my documentation on a local server using mkdocs serve.
  • Running mkdocs serve didn't generate any failures.
  • I have performed a self-review of my own documentation.

@amplitude-dev-docs

Added a note on Start/End Session events to clarify that they do count towards the event volume.
Copy link

github-actions bot commented Dec 8, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ MARKDOWN markdownlint 1 0 0.26s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-114.d19s7xzcva2mw3.amplifyapp.com

@markzegarelli markzegarelli mentioned this pull request Dec 11, 2023
8 tasks
@@ -575,8 +575,9 @@ You can adjust the time window for which sessions are extended. The default sess
Amplitude amplitude = new Amplitude(configuration);
```

By default, Amplitude automatically sends the '[Amplitude] Start Session' and '[Amplitude] End Session' events. Even though these events aren't sent, sessions are still tracked by using `session_id`.
You can also disable those session events.
By default, Amplitude sends the '[Amplitude] Start Session' and '[Amplitude] End Session' events. Even though these events aren't sent, sessions are still tracked by using `session_id`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zheniasemenina This paragraph is unclear. First sentence says that Amplitude sends those events, but the second says otherwise. Can you confirm which is correct? Is it the same as the iOS-Swift article?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markzegarelli This is incorrect, but it stems from the previous version of this SDK: it used to say 'By default, '[Amplitude] Start Session' and '[Amplitude] End Session' events aren't sent. Even though these events..'
So we can get rid of this piece now.

docs/data/sdks/android-kotlin/index.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants