refactor(remote config): consume remote config package in session replay #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwalker3690
force-pushed
the
kwallach/generic-remote-config
branch
from
bff8950
to
a9c64d0
Compare
kwalker3690
requested review from
izaaz,
justin-fiedler,
Mercy811 and
lewgordon-amplitude
lewgordon-amplitude
approved these changes
May 13, 2024
packages/analytics-remote-config/src/remote-config-idb-store.ts
Outdated
Show resolved
Hide resolved
packages/session-replay-browser/test/session-replay-factory.test.ts
Outdated
Show resolved
Hide resolved
Mercy811
approved these changes
May 13, 2024
1 task
…at runs on node 16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes the remote config package more generic, as well as consumes it in Session Replay, replacing the internal package
Checklist