-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(session replay) use custom IDB store for event management #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwalker3690
force-pushed
the
kwallach/revise-store
branch
4 times, most recently
from
May 13, 2024 15:25
35fe789
to
9241f52
Compare
kwalker3690
changed the title
Kwallach/revise store
refactor(session replay) use custom IDB store for event management
May 14, 2024
kwalker3690
force-pushed
the
kwallach/revise-store
branch
from
May 15, 2024 14:57
c73c8d2
to
5bd77fc
Compare
lewgordon-amplitude
approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Nothing hard blocking, but I think some suggestions might make the code trimmer.
…no longer possible
kwalker3690
force-pushed
the
kwallach/revise-store
branch
from
May 15, 2024 23:57
d5315e5
to
2725066
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates the SR SDK off of
idb-keyval
to a more robust IDB schema that will allow us more flexibility in the implementation of Targeted Replay Capture.The current replay being captured will add events to
sessionCurrentSequence
. Once that list is large enough, as well as on blur, we will move that list tosequencesToSend
, which will automatically provide it a sequence id. Then the list will be sent to the backend, upon a successful API response we will delete the list fromsequencesToSend
. In this model, IDB will be the source of truth for events (previously, they were also stored in memory).https://www.loom.com/share/d3a5b4bc26b84f2d92d49458e9f7794f
Checklist