fix(analytics-browser): prevent error being thrown when server-side rendering #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piyushchauhan2011
approved these changes
Apr 23, 2024
|
Looks okay to me, hopefully we can merge these changes so it will be helpful to utilize them soon |
izaaz
reviewed
May 16, 2024
| config.loggerProvider.debug( | ||
| 'Network connectivity checker plugin is disabled because navigator is not available.', | ||
| ); | ||
| config.offline = true; |
There was a problem hiding this comment.
Is there a reason this needs to be defaulted to true? If navigator isn't available, then we want to default to assuming there's internet connectivity? Offline mode is mostly best effort.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #710 - I'm not sure why, but this library gets pulled into the SSR part of my next.js project.
Likely a treeshaking issue. It then throws and error because navigtator is missing.
Checklist