Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expose block selector config from rrweb to SR plugin/SDK. #631

Open
wants to merge 250 commits into
base: main
Choose a base branch
from

Conversation

jackson-amplitude
Copy link

Summary

Exposes the block selector from rrweb to support ebay's case of blocking based on selector.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:
    no

kevinpagtakhan and others added 30 commits June 5, 2023 15:17
 - @amplitude/analytics-browser-test@1.4.0-beta.1
 - @amplitude/analytics-browser@1.10.6-beta.0
 - @amplitude/analytics-client-common@1.0.0-beta.1
 - @amplitude/analytics-core@1.0.0-beta.1
 - @amplitude/analytics-node-test@1.0.0-beta.1
 - @amplitude/analytics-node@1.1.7-beta.0
 - @amplitude/analytics-react-native@1.1.8-beta.0
 - @amplitude/analytics-types@1.0.0-beta.1
 - @amplitude/marketing-analytics-browser@1.0.0-beta.1
 - @amplitude/plugin-page-view-tracking-browser@1.0.0-beta.1
 - @amplitude/plugin-web-attribution-browser@1.0.0-beta.1
 - @amplitude/analytics-browser-test@1.4.0
 - @amplitude/analytics-browser@1.10.6
 - @amplitude/analytics-client-common@1.0.0
 - @amplitude/analytics-core@1.0.0
 - @amplitude/analytics-node-test@1.0.0
 - @amplitude/analytics-node@1.1.7
 - @amplitude/analytics-react-native@1.1.8
 - @amplitude/analytics-types@1.0.0
 - @amplitude/marketing-analytics-browser@1.0.0
 - @amplitude/plugin-page-view-tracking-browser@1.0.0
 - @amplitude/plugin-web-attribution-browser@1.0.0
* fix: allow optionally starting new session on setUserId

* fix: update setUserId(id, startNewSession) always start new session if requested

* fix: update web-client to allow for `startNewSession`

* chore: update session integration tests

* chore: test fix

* chore: revert interface changes

* chore: revert interface changes in tests

* chore: update tests for new session change logic

* chore: fix set user test
 - @amplitude/analytics-browser-test@1.4.1
 - @amplitude/analytics-browser@1.10.7
 - @amplitude/marketing-analytics-browser@1.0.1
 - @amplitude/plugin-page-view-tracking-browser@1.0.1
 - @amplitude/plugin-web-attribution-browser@1.0.1
* feat: log response body from API to logger

* fix: fix test for 429 status, extend 'log unexpected error' test to increase coverage

* fix: add status code to response logging

* chore: typo

* fix: reject send errors

* chore: resolve promise for req.on('error'), remove throw error from SDK

* chore: remove superfluous logging on success

* chore: only log intermediate responses prior to retry

* chore: remove duplicate logging on "other": response

* chore: clean up test logic

---------

Co-authored-by: Andrey Sokolov <andrey.sokolov@amplitude.com>
 - @amplitude/analytics-browser-test@1.4.2
 - @amplitude/analytics-browser@1.10.8
 - @amplitude/analytics-client-common@1.0.1
 - @amplitude/analytics-core@1.1.0
 - @amplitude/analytics-node-test@1.0.1
 - @amplitude/analytics-node@1.2.0
 - @amplitude/analytics-react-native@1.1.9
 - @amplitude/analytics-types@1.1.0
 - @amplitude/marketing-analytics-browser@1.0.2
 - @amplitude/plugin-page-view-tracking-browser@1.0.2
 - @amplitude/plugin-web-attribution-browser@1.0.2
* feat: added extendSession() method to Browser Client

* fix: implement extendSession() method for RN Client and Browser Client factory

* chore: code clean up

* chore: fix mocks

* chore: handle deferred config

* chore: fix comment in test

* chore: add snippet proxy test for extendSession()
 - @amplitude/analytics-browser-test@1.4.3
 - @amplitude/analytics-browser@1.11.0
 - @amplitude/analytics-client-common@1.0.2
 - @amplitude/analytics-core@1.1.1
 - @amplitude/analytics-node-test@1.0.2
 - @amplitude/analytics-node@1.2.1
 - @amplitude/analytics-react-native@1.2.0
 - @amplitude/analytics-types@1.2.0
 - @amplitude/marketing-analytics-browser@1.0.3
 - @amplitude/plugin-page-view-tracking-browser@1.0.3
 - @amplitude/plugin-web-attribution-browser@1.0.3
* fix: do not fetch advertising Id if adid tracking is disabled

* fix: ios compilation
 - @amplitude/analytics-react-native@1.2.1
 - @amplitude/analytics-browser-test@1.4.4
 - @amplitude/analytics-browser@1.11.1
 - @amplitude/marketing-analytics-browser@1.0.4
 - @amplitude/plugin-page-view-tracking-browser@1.0.4
 - @amplitude/plugin-web-attribution-browser@1.0.4
 - @amplitude/analytics-browser-test@1.4.5
 - @amplitude/analytics-browser@1.11.2
 - @amplitude/analytics-client-common@1.0.3
 - @amplitude/analytics-core@1.1.2
 - @amplitude/analytics-node-test@1.0.3
 - @amplitude/analytics-node@1.2.2
 - @amplitude/analytics-react-native@1.2.2
 - @amplitude/analytics-types@1.2.1
 - @amplitude/marketing-analytics-browser@1.0.5
 - @amplitude/plugin-page-view-tracking-browser@1.0.5
 - @amplitude/plugin-web-attribution-browser@1.0.5
liuyang1520 and others added 30 commits October 26, 2023 16:40
* feat: make auto-tracking solely use css selector allowlist

* feat: add default allowlist class

* docs: update readme
 - @amplitude/plugin-default-event-tracking-advanced-browser@0.1.0
 - @amplitude/plugin-default-event-tracking-advanced-browser@0.1.1
 - @amplitude/plugin-default-event-tracking-advanced-browser@0.1.2
 - @amplitude/plugin-default-event-tracking-advanced-browser@0.1.3
* feat: add default data attr selector

* refactor: adjust the order of data attr to be ahead of the class
 - @amplitude/plugin-default-event-tracking-advanced-browser@0.2.0
 - @amplitude/plugin-session-replay-browser@0.7.0
 - @amplitude/session-replay-browser@0.4.0
* fix: skip parent element event when it is not target

* feat: limit to only the innermost allowed element
 - @amplitude/plugin-default-event-tracking-advanced-browser@0.2.1
 - @amplitude/plugin-session-replay-browser@0.7.1-beta.0
 - @amplitude/session-replay-browser@0.5.0-beta.0
 - @amplitude/plugin-session-replay-browser@0.7.1
 - @amplitude/session-replay-browser@0.5.0
* feat: integrate with selector

* refactor: better naming and using constant
 - @amplitude/plugin-default-event-tracking-advanced-browser@0.3.0
 - @amplitude/plugin-session-replay-browser@0.8.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet