feat: add diagnostic #568
Open
feat: add diagnostic #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mercy811
force-pushed
the
feat-add-diagnostics
branch
from
18f63df
to
51a5ff1
Compare
Mercy811
requested review from
kevinpagtakhan,
justin-fiedler,
yuhao900914,
nehabhambhani and
shweta-amplitude
yuhao900914
reviewed
Aug 28, 2023
justin-fiedler
requested changes
Sep 6, 2023
There was a problem hiding this comment.
Thanks @Mercy811. See comments. Since we only need to hook into "flush" configuring this as a Plugin is probably not needed, instead we can mostly treat it like the other providers.
We can probably use the config.transportProvider to send the diagnotics but should be careful with the storage (config.storageProvider) so these events aren't mixed with "real" events.
Mercy811
force-pushed
the
feat-add-diagnostics
branch
from
c7bf5fa
to
417eed4
Compare
Mercy811
commented
Oct 12, 2023
Mercy811
commented
Oct 12, 2023
Mercy811
force-pushed
the
feat-add-diagnostics
branch
from
80a8114
to
4a8f99d
Compare
justin-fiedler
requested changes
Oct 27, 2023
justin-fiedler
approved these changes
Nov 8, 2023
Co-authored-by: Justin Fiedler <justin.fiedler@amplitude.com>
Co-authored-by: Justin Fiedler <justin.fiedler@amplitude.com>
1. account time in minutes 2. browser diagnostic default apiKey
Co-authored-by: Justin Fiedler <justin.fiedler@amplitude.com>
Mercy811
force-pushed
the
feat-add-diagnostics
branch
from
fa718e9
to
d2bbc02
Compare
- @amplitude/analytics-browser@2.4.0-featadddiagnostics.0 - @amplitude/analytics-client-common@2.0.8-featadddiagnostics.0 - @amplitude/analytics-core@2.2.0-featadddiagnostics.0 - @amplitude/analytics-types@2.4.0-featadddiagnostics.0 - @amplitude/plugin-global-user-properties@1.2.2-featadddiagnostics.0 - @amplitude/plugin-page-view-tracking-browser@2.0.14-featadddiagnostics.0 - @amplitude/plugin-web-attribution-browser@2.0.14-featadddiagnostics.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://amplitude.atlassian.net/browse/AMP-81179
Send diagnostic events when the SDK drops events
This feature is enabled by default and can be disabled by setting
config.diagnosticProvidertoundefinedChecklist