Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add garner jargon and substitutions #1186

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Nytelife26
Copy link
Member

This relates to...

The splitting of PR #802.

Before this PR can be processed, it must be determined how many of
the checks already exist within Proselint.

Rationale

TO BE DONE.

Changes

TO BE DONE.

Features

TO BE DONE.

Bug Fixes

TO BE DONE.

Breaking Changes and Deprecations

TO BE DONE.

@Nytelife26 Nytelife26 requested a review from suchow as a code owner July 5, 2021 14:30
@Nytelife26 Nytelife26 added cat: new-rule Issues and PRs related to new proselint rules. priority: low Issues and PRs that should be resolved, but can be postponed. status: postponed Issues and PRs that are being temporarily set aside in favour of others. type: feat Issues and PRs related to new features. version: minor Issues and PRs with new features belonging to the next minor release. labels Jul 5, 2021
@codecov
Copy link

codecov bot commented Jul 5, 2021

Codecov Report

Merging #1186 (53cc988) into main (c17ad87) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1186      +/-   ##
==========================================
+ Coverage   94.72%   94.79%   +0.06%     
==========================================
  Files          83       85       +2     
  Lines        1213     1229      +16     
==========================================
+ Hits         1149     1165      +16     
  Misses         64       64              
Flag Coverage Δ
macos-latest 94.79% <100.00%> (+0.06%) ⬆️
py3.6 94.28% <100.00%> (+0.07%) ⬆️
py3.7 94.28% <100.00%> (+0.07%) ⬆️
py3.8 94.79% <100.00%> (+0.06%) ⬆️
py3.9 94.79% <100.00%> (+0.06%) ⬆️
pypypy3 94.28% <100.00%> (+0.07%) ⬆️
ubuntu-latest 94.79% <100.00%> (+0.06%) ⬆️
windows-latest 94.79% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
proselint/checks/garner/jargon.py 100.00% <100.00%> (ø)
proselint/checks/garner/substitutions.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c17ad87...53cc988. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jul 5, 2021

Danger has errored

[!] Invalid Dangerfile file: proselint is not in the user`s PATH, or it failed to install

 #  from Dangerfile:2
 #  -------------------------------------------
 #  # Look for prose issues
 >  prose.lint_files
 #  
 #  -------------------------------------------

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: new-rule Issues and PRs related to new proselint rules. priority: low Issues and PRs that should be resolved, but can be postponed. status: postponed Issues and PRs that are being temporarily set aside in favour of others. type: feat Issues and PRs related to new features. version: minor Issues and PRs with new features belonging to the next minor release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants