Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem when an artist has a dash in its name, like AC-DC. #2440

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

woodspire
Copy link

This fix will correctly grab the song name from the "artist" "song number" "song name" string.

@lachlan-00
Copy link
Member

so webdav tries to identify songs by splitting the text?

Changing this would also just start affecting artists with the spaces (' - ')

Aga - Wilk - 6 - Driving Me Mad.mp3

I also see that if i have a various artist album it's empty when i go to the artist themselves.
image

This all needs to be done better.

@lachlan-00
Copy link
Member

I haven't looked into this but is there a reason why it doesn't use the folder path instead? that would avoid making simple mistakes like this

@lachlan-00
Copy link
Member

oh and a third problem is webdav plays aren't recorded for the user.

@lachlan-00
Copy link
Member

@woodspire if you keep the ' - ' and take off the 3 at the end this should cover most cases. as well

$splitname = explode(' - ', (string) $name);

@lachlan-00
Copy link
Member

in webdav file add in a stat insert
image

(haven't worked out if the user is stored anywhere but it would be good to at least record that stat)

Stats::insert($this->libitem->type, $this->libitem->id, 0, 'Ampache WebDAV', null, 'stream');

@lachlan-00
Copy link
Member

So the only thing i see left is that the directory structure includes artists and albums without songs but i don't know enough about SABRE\DAV to work that one out but we can ignore that as it's not really affecting this pull

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants