more errors on github actions

ampache · May 13, 2024 · 9f963a9 · 9f963a9
1 parent 7a08e2c
commit 9f963a9
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/src/Module/Application/SmartPlaylist/UpdatePlaylistAction.php b/src/Module/Application/SmartPlaylist/UpdatePlaylistAction.php
@@ -55,8 +55,11 @@ public function run(ServerRequestInterface $request, GuiGatekeeperInterface $gat
             (int) ($request->getQueryParams()['playlist_id'] ?? 0)
         );
 
-        $data = (array)$request->getParsedBody();
-        if ($playlist->has_access()) {
+        $data = $request->getParsedBody();
+        if (
+            is_array($data) &&
+            $playlist->has_access()
+        ) {
             $playlist->set_rules($data);
             $playlist->update();
             $playlist->format();

diff --git a/src/Module/Broadcast/Broadcast_Server.php b/src/Module/Broadcast/Broadcast_Server.php
@@ -348,7 +348,7 @@ protected function unregisterListener(ConnectionInterface $conn): void
     {
         foreach ($this->listeners as $broadcast_id => $brlisteners) {
             $lindex = array_search($conn, $brlisteners);
-            if ($lindex) {
+            if ($lindex && isset($this->listeners[$broadcast_id][$lindex])) {
                 unset($this->listeners[$broadcast_id][$lindex]);
                 echo "[info]Listener left broadcast " . $broadcast_id . "." . "\r\n";
 

diff --git a/src/Module/Util/Mailer.php b/src/Module/Util/Mailer.php
@@ -251,7 +251,7 @@ public function send($phpmailer = null): bool
         if ($retval === true) {
             return true;
         } else {
-            debug_event(self::class, 'Did not send mail. ErrorInfo: ' . ($mail->ErrorInfo ?? ''), 5);
+            debug_event(self::class, 'Did not send mail. ErrorInfo: ' . $mail->ErrorInfo, 5);
 
             return false;
         }