Skip to content

Commit

Permalink
Prepare for separation of JS from PHP; header.inc.php done (#3939)
Browse files Browse the repository at this point in the history
* add `npm run build` after your `npm install` commands
  • Loading branch information
mitchray committed May 2, 2024
1 parent 8ac6da8 commit 3b6f2e2
Show file tree
Hide file tree
Showing 29 changed files with 2,505 additions and 696 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -53,3 +53,4 @@ web.config
*~
.php-cs-fixer.cache
.phpunit.result.cache
public/dist/
1 change: 1 addition & 0 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
"doctrine/cache": "^2",
"gettext/gettext": "^5",
"gettext/translator": "^1.2",
"idleberg/vite-manifest": "^1.0",
"james-heinrich/getid3": "dev-master",
"jwilsson/spotify-web-api-php": "^6",
"krixon/xbmc-php-rpc": "dev-master",
Expand Down
238 changes: 236 additions & 2 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docker/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ There are a few docker files I've been using to build and test that have helped
Anyone with a bit of docker knowledge should be able to get up and running but here's the gist.

* Run `docker-compose up` to start the container
* Don't forget to run `composer install` & `npm install` in the project root
* Don't forget to run `composer install` & `npm install` & `npm run build` in the project root

After you're up and running you should be able to install as normal. (MySQL is not included in the docker files)

Expand Down
3 changes: 2 additions & 1 deletion docs/RELEASE-PROCESS.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,11 @@ php7.4 /usr/local/bin/composer install
php8.0 /usr/local/bin/composer install
```

* Install npm packages
* Install npm packages & build javascript files

```shell
npm install
npm run build
```

* Remove broken symbolic links
Expand Down
3 changes: 2 additions & 1 deletion docs/examples/update_from_git.sh
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,6 @@ php bin/cli run:updateCatalog -t
### You don't always need to do this but some people might want to keep composer packages updated here
#composer install --prefer-source --no-interaction

### NPM install is now required to copy all the javascript packages
### NPM is now required to handle all the javascript packages
npm install
npm run build

0 comments on commit 3b6f2e2

Please sign in to comment.