Minify and secure docker image #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR, I shall review, test everything and then proceed. |
|
Is this review enough? I don't have write access. May I ask you to merge it, @amitshekhariitbhu ? |
Yuri-SN
added a commit
to Yuri-SN/go-backend-clean-architecture
that referenced
this pull request
Aug 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heyho! I think you may consider updating the Dockerfile to make the image smaller and more secure
This change should minify it by separating the builder image with all of the Go tools needed to build the executable and the second image that consists of only the executable itself. It also uses a minimal base image so there are close to no tools that could be exploited, and the user is set to nonroot