New feature: File download support #702
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added file downloading support for admin - Added tests for new feature
|
This PR solves the #701 issue. |
1 task
- File roots changed - Issue with unsecure file path change - Made possibility to read files without download
… into works_with_files
|
I decided that the user wants to have not only a download method but a reading method too. Now, besides the download method, there's an additional option to open files directly in a browser. Additionally, I've addressed a security concern from the previous version. Instead of using file paths in the URL, which is insecure. Now the result looks like: Please let me know when you check my MR. I'm will grateful for the feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now if the database value is the file path and the file exists it will be shown as a downloadable file
Before:
After:
Changes affect templates: deteils.html, list.html