Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add implementation of method exec for Container #337

Merged
merged 1 commit into from
Apr 21, 2020
Merged

add implementation of method exec for Container #337

merged 1 commit into from
Apr 21, 2020

Conversation

lumimul
Copy link

@lumimul lumimul commented Apr 18, 2020 •
edited by amihaiemil

PR for #168
Added method to create an Exec.

@amihaiemil amihaiemil self-assigned this Apr 19, 2020
Repository owner deleted a comment from 0crat Apr 19, 2020
Repository owner deleted a comment from 0crat Apr 19, 2020
Repository owner deleted a comment from 0crat Apr 19, 2020
Repository owner deleted a comment from 0crat Apr 19, 2020
Repository owner deleted a comment from 0crat Apr 19, 2020
Repository owner deleted a comment from 0crat Apr 19, 2020
Repository owner deleted a comment from 0crat Apr 19, 2020
@0crat
Copy link
Collaborator

0crat commented Apr 19, 2020

@amihaiemil/z not enough funds available in the project, can't set budget of job #337, see §21; @amihaiemil/z will get no money on completion; in order to fix that, add funds to the project and assign the job again

amihaiemil
amihaiemil requested changes Apr 19, 2020
View reviewed changes
Copy link
Owner

@amihaiemil amihaiemil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lumimul Please have a look :D

src/main/java/com/amihaiemil/docker/Execs.java Outdated Show resolved Hide resolved
src/main/java/com/amihaiemil/docker/Execs.java Outdated Show resolved Hide resolved
@amihaiemil amihaiemil changed the title #169 add implementation of method create for Exec add implementation of method create for Exec Apr 19, 2020
amihaiemil
amihaiemil reviewed Apr 20, 2020
View reviewed changes
Copy link
Owner

@amihaiemil amihaiemil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lumimul See my answer :)

src/main/java/com/amihaiemil/docker/Execs.java Outdated Show resolved Hide resolved
@lumimul lumimul changed the title add implementation of method create for Exec add implementation of method exec for Container Apr 20, 2020
@amihaiemil
Copy link
Owner

@lumimul Looks good, thanks!

@amihaiemil
Copy link
Owner

@rultor merge it please

@amihaiemil
Copy link
Owner

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Apr 21, 2020

@rultor merge it please

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 8cd5715 into amihaiemil:master Apr 21, 2020
@rultor
Copy link
Collaborator

rultor commented Apr 21, 2020

@rultor merge it please

@amihaiemil Done! FYI, the full log is here (took me 7min)

@rultor
Copy link
Collaborator

rultor commented Apr 21, 2020

@rultor merge

@amihaiemil @lumimul The pull request is closed already, so I can't merge it

@rultor
Copy link
Collaborator

rultor commented Apr 21, 2020

@rultor merge

@amihaiemil I'm sorry, I don't understand you :( Check this page and try again please

@0crat
Copy link
Collaborator

0crat commented Apr 21, 2020

Job #337 is not in the agenda of @amihaiemil/z, can't set title

@0crat
Copy link
Collaborator

0crat commented Apr 21, 2020

Job was finished in 44 hours, bonus for fast delivery is possible (see §36)

@amihaiemil
Copy link
Owner

@lumimul Thanks a lot!

@0crat 0crat removed the scope label Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amihaiemil amihaiemil amihaiemil requested changes

Assignees

@amihaiemil amihaiemil

Labels
role/REV
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lumimul @0crat @amihaiemil @rultor