Updated bracket-bevy to Bevy 0.11.0 #342
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows using these types in structs that want to derive Debug themselves
… using the native gl backend
…bracket-lib into IAmSegfault-window-improvements
…mpel/bracket-lib into AndreasHempel-noise/add-debug-derive
…/flexible consoles after CLS
* export colors mods separately to aid precise imports * use updated bracket-color
…into lecoqjacob-bevy_point
…culations, the astar example actually finds a path now (updates logic from amethyst#268)
…hed testing and some more issues), relax dependency versions to make releases easier.
…minal colors look right now.
…on Bevy 0.9. There are some issues left to resolve, particularly why is it spawning continuous Resize messages on Windows?
Replaced stages with stageless sets. Replaced the function body of update_mouse_position to handle Window entities.
Updated systems initialized by bterm_builder to use the new simplified system scheduler in Bevy 0.11.0. Bumped up Bevy dependencies in bracket-color and bracket-geometry to Bevy 0.11.0. Fixed bug with inverted y-coordinates for the mouse's world space position in fn update_mouse_position.
IAmSegfault
changed the title
|
Is this intended to support GUI pseudo-terminals only? I'm trying to port my existing project using bevy + bracketlib over to using your updated bracket-bevy but disabling default features on bracketlib and enabling curses still leads to bevy creating a GUI terminal |
|
Yes, bracket-bevy utilizes Bevy's renderer to provide a gui based pseudo terminal. I'm not sure if the curses backend is currently in a working state. |
|
Thanks for the update. I'll keep using my own much less capable hacked-together bracket+bevy stack (https://github.com/sparr/ascii-factory/blob/main/src/bevy_bracket.rs) for now. I'd love to contribute here, but my Rust isn't sharp enough yet to dive into a codebase as complex as yours. |
|
After a really long absence, I'm trying to schedule some bracket lib in the
next month. Toddler, burnout, Covid and a mother with extreme health issues
got me.
My plan is to bring it up to the latest Bevy, and make some better
examples. Recent Bevy changes will mean redoing some parts. (The Bevy
changes also delayed the next book I'm working on, which uses Bevy.)
…On Sat, Dec 30, 2023, 10:57 AM sparr ***@***.***> wrote:
Thanks for the update. I'll keep using my own much less capable
hacked-together bracket+bevy stack for now. I'd love to contribute here,
but my Rust isn't sharp enough yet to dive into a codebase as complex as
yours.
—
Reply to this email directly, view it on GitHub
<#342 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADRU4344HE7I5SZHM3KMUX3YMBBYTAVCNFSM6AAAAAAYY2YEVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZSGU3DINZYHA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in this issue, I updated bracket-bevy to use Bevy
0.10.1.I Replaced stages with stageless sets. I also Replaced the function body of update_mouse_position to handle Window entities, with a workaround for the panic I mentioned. I also edited the Msaa resource so it reflects that it's an enum. I'm not sure how this branch is being used so if you would prefer the merge go into master as not to deal with merge conflicts let me know.
EDIT:
I added some changes to this pull request so that bracket-bevy now depends on
Bevy 0.11.0. Changes were made to use the new scheduling system in0.11.0. More testing is likely going to be needed however before merging this pull request.I did notice two different bugs that occur rarely that both seem to happen once per 70-100 application launches. The first one appears to happen no matter what and results in a window with a gray screen and none of the systems appear to run. I'm not exactly sure what causes it because I can only reproduce the issue when running the application from a terminal, running from Visual Studio Code cannot seem to trigger the issue.
The second appears to happen if there are two or more different systems in the application that call the
set()method onBracketContext. Changing the schedules of the systems and forcing them to execute in a specific order using.after()on the systems did not seem to resolve the issue. In this case it will occasionally cause this line in Bevy's render function to panic.