Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SARIT, add स्कन्दपुराणम् #89

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

epicfaace
Copy link
Contributor

@epicfaace epicfaace commented Aug 7, 2022

  • Add sarit.py to import from SARIT
  • Make gretil.py more generic so its functions can be reused by sarit parsing code. In a future PR, I will move these functions to a "tei_utils.py" file.
  • Add स्कन्दपुराणम् from SARIT

image

image

@akprasad
Copy link
Contributor

akprasad commented Aug 8, 2022

So far so good! As part of the test plan, let's make sure the original gretil script still works.

@epicfaace epicfaace changed the title Support SARIT Support SARIT, add स्कन्दपुराण Aug 12, 2022
@epicfaace epicfaace marked this pull request as ready for review August 12, 2022 20:44
@epicfaace epicfaace changed the title Support SARIT, add स्कन्दपुराण Support SARIT, add स्कन्दपुराणम् Aug 12, 2022
@epicfaace
Copy link
Contributor Author

@akprasad should be ready for review now, and GRETIL import still works.

@epicfaace
Copy link
Contributor Author

Actually, there are two issues with skandapuranam:

  1. the TEI XML file is incomplete ("The edition of the Skandapurāṇa is an ongoing project, so far the first 69 Adhyāyas have been covered. As further volumes are published this file will be extended.")
  2. no xml:id attributes in the TEI XML (https://raw.githubusercontent.com/sarit/SARIT-corpus/master/skandapurana.xml):

image

@akprasad
Copy link
Contributor

Forgive the late follow-up. At a minimum, any verse/paragraph we display should have an xml:id defined, as this is how we cross-link translations, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants