Fixed bitrate calculation #2018
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zarik5
requested changes
Mar 6, 2024
Comment on lines
+289
to
+290
| if dt_throughput != Duration::ZERO { | ||
| // TODO: Assuming UDP for 42.0, for TCP it would be 54.0 instead. This loses a bit of accuracy for TCP (it's still a good estimate) but I could need to import session settings in the future |
There was a problem hiding this comment.
I would like you to make this correct for TCP from the start
| @@ -271,6 +271,7 @@ fn connection_pipeline(capabilities: ClientCapabilities) -> ConResult { | |||
| stream_socket.subscribe_to_stream::<Haptics>(HAPTICS, MAX_UNREAD_PACKETS); | |||
| let statistics_sender = stream_socket.request_stream(STATISTICS); | |||
|
|
|||
| let mut actual_throughput_inseconds: f32 = 30_000_000.0; | |||
There was a problem hiding this comment.
Rename to actual_throughput_bps
| @@ -94,6 +94,15 @@ impl StatisticsManager { | |||
| } | |||
| } | |||
|
|
|||
| pub fn report_throughput_client(&mut self, target_timestamp: Duration, throughput_client: f32) { | |||
| @@ -314,6 +314,7 @@ pub struct ClientStatistics { | |||
| pub rendering: Duration, | |||
| pub vsync_queue: Duration, | |||
| pub total_pipeline_latency: Duration, | |||
| pub throughput_client: f32, | |||
| @@ -99,6 +99,7 @@ impl BitrateManager { | |||
| timestamp: Duration, | |||
| network_latency: Duration, | |||
| decoder_latency: Duration, | |||
| throughput_reported_client: f32, | |||
zarik5
force-pushed
the
master
branch
2 times, most recently
from
d01478e
to
005c4c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made some changes I mentioned on discord (elpotas there) for a more accurate bitrate at client stimation, then used for Statistics/plots and an improved adaptive bitrate. This fixes some issues with adaptive too, that saw huge drops in bitrate if network latency increased for any reason.