Draft: Linux pipewire integration #1973
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't reviewed completely. But linux specific code should go in |
Please don't review it completely yet, its just in barely compilable state, not ready for any serious review of the code itself. |
|
Cool! Any way to help? |
no not really unless you wanna pull a night of just reading documentation on oboe(not the rust crate but the google software one) oh and you somehow figure out what we're doing wrong so you have to know Rust too |
Meister1593
force-pushed
the
pipewire-microphone
branch
3 times, most recently
from
69a43ad
to
725909f
Compare
zarik5
force-pushed
the
master
branch
2 times, most recently
from
d01478e
to
005c4c7
Compare
Changed chan size to proper, as well as audio format to f32 Uncommitted older changes Updated pipewire libs, adapted code to new pipewire lib version, issue with moving threads for pipewire Sink creation done, pipewire-rs and alvr compiled, no buffer copying yet Dropped unnecessary custom pw-rs, tokio. Code cleanup and move to single mainloop thread. Cfg cleanup Changed cfgs to not linux for android client compatibility Removed unnecessary pipewire code from client Renamed microphone output for linux pipewire, removed Audio Type Updated Cargo.lock Started implementing channels for pipewire to handle buffers Implemented basic buffer, almost completely non functional, code related to actual bufferring needs to be re-added Refactored flow, experimenting with byte types, order, etc Added comment about graceful shutdown Fixed steamvr shutdown. Experimenting with alternative ways to process streamed data
Meister1593
force-pushed
the
pipewire-microphone
branch
from
725909f
to
62cffbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not done by any means, just put up for anyone to see how things are progressing
So far: main flow (pipewire source, getting data from one place to another) is kinda done, but i've yet to determine why only thing i get is pops into mic, it might be a multiple issues at once (buffer overload + trying to push all at once)
Other issues are listed in TODO's