fix: Resolve agent lint, test build errors, enable test linting

Author: alvinveroy

eslint.config.js

@@ -16,8 +16,8 @@ module.exports = [
       "*.config.js", // Ignores other .config.js files (e.g., vitest.config.js)
       "*.config.ts", // Ignores .config.ts files
       "scripts/",
-      "src/lib/__tests__/**/*.ts", // More specific for these paths
-      "src/tests/**/*.ts"         // More specific for these paths
+      // "src/lib/__tests__/**/*.ts", // Re-enable linting for test files
+      // "src/tests/**/*.ts"         // Re-enable linting for test files
     ],
   },
 

src/lib/__tests__/query-refinement.test.ts

@@ -1,4 +1,4 @@
-import { describe, it, expect, vi, beforeEach, afterEach, beforeAll, type Mock, type MockedFunction, afterAll } from 'vitest';
+import { describe, it, expect, vi, beforeEach, afterEach, beforeAll, type Mock, type MockedFunction } from 'vitest';
 import { QdrantClient } from '@qdrant/js-client-rest';
 
 // 2. Mock external dependencies FIRST
@@ -63,7 +63,7 @@ describe('Query Refinement Tests', () => {
 
   describe('searchWithRefinement', () => {
     let searchWithRefinementSUT_local: (typeof import('../query-refinement.js'))['searchWithRefinement'];
-    let mockRefineQuery_for_searchTest: Mock<[string, DetailedQdrantSearchResult[], number], string>;
+    let mockRefineQuery_for_searchTest: MockedFunction<(query: string, results: DetailedQdrantSearchResult[], currentRelevance: number) => string>;
 
     beforeEach(async () => {
       vi.resetModules(); // Ensure clean state for vi.doMock
@@ -181,9 +181,9 @@ describe('Query Refinement Tests', () => {
 
   describe('refineQuery (main dispatcher - testing original logic)', () => {
     let refineQuerySUT_local: (typeof import('../query-refinement.js'))['refineQuery'];
-    let mockBroadenQuery_local: Mock<[string], string>;
-    let mockFocusQuery_local: Mock<[string, DetailedQdrantSearchResult[]], string>;
-    let mockTweakQuery_local: Mock<[string, DetailedQdrantSearchResult[]], string>;
+    let mockBroadenQuery_local: MockedFunction<(query: string) => string>;
+    let mockFocusQuery_local: MockedFunction<(query: string, results: DetailedQdrantSearchResult[]) => string>;
+    let mockTweakQuery_local: MockedFunction<(query: string, results: DetailedQdrantSearchResult[]) => string>;
 
     beforeEach(async () => {
       vi.resetModules(); // Ensure clean state for vi.doMock

src/lib/agent.ts

@@ -1189,22 +1189,19 @@ export async function runAgentLoop(
         agentState.finalResponse = "I apologize, but I couldn't complete the full analysis due to a timeout. " +
           "Here's what I found so far: " +
           agentState.steps.map((s: AgentStep) => {
-            let displayOutput: string;
-            if (typeof s.output === 'string') {
-              displayOutput = s.output;
-            } else if (s.output === null || s.output === undefined) {
-              // Explicitly convert null or undefined to their string representations
-              displayOutput = String(s.output); 
+            const toolName = s.tool; // s.tool is already a string
+            let outputString: string;
+            if (typeof s.output === 'object' && s.output !== null) {
+              try {
+                outputString = JSON.stringify(s.output);
+              } catch {
+                outputString = String(s.output); // Fallback for non-serializable objects
+              }
             } else {
-              // For other types (objects, arrays, functions, etc.)
-              // Try JSON.stringify first. If it returns undefined (e.g., for a function),
-              // then fallback to String(s.output).
-              const jsonStringified = JSON.stringify(s.output);
-              displayOutput = jsonStringified === undefined ? String(s.output) : jsonStringified;
+              outputString = String(s.output); // Handles primitives, null, undefined
             }
-            // Ensure we have a string, then take a substring.
-            const safePreviewText = (displayOutput || '').substring(0, 200);
-            return `Used ${s.tool} and found: ${safePreviewText}...`;
+            const safePreviewText = (outputString || 'No output').substring(0, 200);
+            return `Used ${toolName} and found: ${safePreviewText}...`;
           }).join("\n\n");
       }
     }