Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation tooltip reposition fix #4020

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

JayBox325
Copy link
Contributor

I have adjusted how the navigation tooltips appear. Where they were not always central when positioned with top: -2px after I'd made it look how I wanted for my design.

I have positioned the tooltip with top: 50%; transform: translate3d(0, -50%, 0); so it's always centred with the dot. Bear in mind this includes no cross-browser support in assuming this is done on people's projects with their Sass Compiler.

alvarotrigo and others added 7 commits July 7, 2020 11:31
- Documentation: improved french docs links alvarotrigo#3856
- Documentation: link to elementor + small fixes in french docs
- Documentation: removing old links
Documentation: removing old links
- Documentation: fixed syntax errors
Positioning navigation tooltip with translate -50% and top 50% so it's definitely centrally positioned even after a user has styled it how they want.
@alvarotrigo
Copy link
Owner

alvarotrigo commented Jul 31, 2020

Thanks for that! 👍

Where they were not always central when positioned with top: -2px after I'd made it look how I wanted for my design.

Not always? Under which circumstances?
Can you please provide an isolated reproduction of the issue you are trying to solve?

You can do it on jsfiddle or codepen, with no CSS or JS files external to fullPage.js and the minimum amount of HTML code?

Use empty sections unless strictly necessary for the reproduction. issue that this pull request is trying to solve?

@JayBox325
Copy link
Contributor Author

Exciting, thanks!

See here for what my tooltips looked like and note they're aligned to "top" so they're bobbing down mis-aligned: https://jsfiddle.net/g0b5f3dk/

See here for my CSS fix: https://jsfiddle.net/9ayvm24r/2/

@alvarotrigo
Copy link
Owner

See here for what my tooltips looked like and note they're aligned to "top" so they're bobbing down mis-aligned: https://jsfiddle.net/g0b5f3dk/

I can't see any tooltips there :)

@JayBox325
Copy link
Contributor Author

Here it is again without the top: 50% fix = https://jsfiddle.net/0Lx4mfwt/

@JayBox325 JayBox325 changed the title Patch 1 Navigation tooltip reposition fix Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants