Add binary classification accuracy objective #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #624 +/- ##
=======================================
Coverage 98.95% 98.96%
=======================================
Files 132 133 +1
Lines 4504 4534 +30
=======================================
+ Hits 4457 4487 +30
Misses 47 47
Continue to review full report at Codecov.
|
dsherry
reviewed
Apr 13, 2020
dsherry
reviewed
Apr 13, 2020
| raise ValueError("Length of inputs is 0") | ||
| if len(y_predicted) != len(y_true): | ||
| raise DimensionMismatchError("Inputs have mismatched dimensions: y_predicted has shape {}, y_true has shape {}".format(len(y_predicted), len(y_true))) | ||
| return metrics.accuracy_score(y_true, y_predicted) |
There was a problem hiding this comment.
Nice, this is great. I wonder if there's a good way we can have this sort of validation occur in all objectives. But not necessary for this PR
There was a problem hiding this comment.
Yup, I filed #619 for that :D We can refactor any test code that happens then?
dsherry
reviewed
Apr 13, 2020
dsherry
reviewed
Apr 13, 2020
dsherry
approved these changes
Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #294
Continuation of #584, but using master as the new base (switching in #584 caused a lot of weird merge issues?)