Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin holidays to upgrade prophet #4428

Merged
merged 3 commits into from
May 20, 2024
Merged

Unpin holidays to upgrade prophet #4428

merged 3 commits into from
May 20, 2024

Conversation

MichaelFu512
Copy link
Contributor

Pull Request Description

Closes #4422


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.7%. Comparing base (08ce3c2) to head (967cef4).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #4428   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        357     357           
  Lines      39973   39973           
=====================================
  Hits       39849   39849           
  Misses       124     124           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for taking care of this!

@jeremyliweishih
Copy link
Contributor

thank you!

@MichaelFu512 MichaelFu512 merged commit dc3f283 into main May 20, 2024
27 checks passed
@MichaelFu512 MichaelFu512 deleted the prophet_upgrade branch May 20, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade prophet to 1.1.5 for ARM support
4 participants