Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating binary and multiclass objective classes #419

Closed
wants to merge 0 commits into from

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Feb 25, 2020

As part of #346, we need to split our objectives into binary and multiclass objectives. Closes #373, addresses #294 as well (since we wanted Accuracy to be our default objective)

@codecov
Copy link

codecov bot commented Feb 27, 2020

Codecov Report

Merging #419 into improved_objectives will decrease coverage by 0.41%.
The diff coverage is 98.07%.

Impacted file tree graph

@@                   Coverage Diff                   @@
##           improved_objectives     #419      +/-   ##
=======================================================
- Coverage                98.25%   97.83%   -0.42%     
=======================================================
  Files                      104      115      +11     
  Lines                     3265     3420     +155     
=======================================================
+ Hits                      3208     3346     +138     
- Misses                      57       74      +17
Impacted Files Coverage Δ
evalml/objectives/__init__.py 100% <ø> (ø) ⬆️
evalml/tests/pipeline_tests/test_pipelines.py 100% <100%> (ø) ⬆️
evalml/tests/objective_tests/test_lead_scoring.py 100% <100%> (ø) ⬆️
evalml/objectives/standard_metrics.py 99.51% <100%> (-0.06%) ⬇️
evalml/pipelines/classification/catboost_binary.py 100% <100%> (ø)
evalml/objectives/fraud_cost.py 97.05% <100%> (-2.95%) ⬇️
...egression_pipeline_tests/test_linear_regression.py 100% <100%> (ø)
evalml/pipelines/classification/__init__.py 100% <100%> (ø) ⬆️
...ests/classification_pipeline_tests/test_xgboost.py 100% <100%> (ø)
...ine_tests/classification_pipeline_tests/test_rf.py 100% <100%> (ø)
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91d62ec...7713969. Read the comment docs.

@angela97lin angela97lin self-assigned this Mar 5, 2020
@angela97lin angela97lin changed the title [WIP] Creating binary and multiclass objective classes Creating binary and multiclass objective classes Mar 10, 2020
@angela97lin angela97lin requested review from dsherry and removed request for dsherry March 10, 2020 21:45
evalml/automl/auto_base.py Outdated Show resolved Hide resolved
Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very exciting! I left some suggestions and comments, plus I know we have a discussion scheduled for 30min from now on how binary classification objective optimization should work. Once we do that, I'll try to circle back and add some testing suggestions at some point as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants