-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating binary and multiclass objective classes #419
Conversation
Codecov Report
@@ Coverage Diff @@
## improved_objectives #419 +/- ##
=======================================================
- Coverage 98.25% 97.83% -0.42%
=======================================================
Files 104 115 +11
Lines 3265 3420 +155
=======================================================
+ Hits 3208 3346 +138
- Misses 57 74 +17
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very exciting! I left some suggestions and comments, plus I know we have a discussion scheduled for 30min from now on how binary classification objective optimization should work. Once we do that, I'll try to circle back and add some testing suggestions at some point as well.
7713969
to
91c2b3a
Compare
As part of #346, we need to split our objectives into binary and multiclass objectives. Closes #373, addresses #294 as well (since we wanted Accuracy to be our default objective)