Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lists as acceptable hyperparameter ranges in AutoMLSearch #2028

Merged
merged 12 commits into from Mar 25, 2021

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Mar 24, 2021

Closes #2015

To support lists as parameters for our components, we are removing lists as acceptable hyperparameter ranges in the pipeline_parameters parameter to AutoMLSearch. This is okay, because users can still use skopt.space.Categorical to achieve the same functionality.

@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #2028 (d3594db) into main (cfcfe68) will not change coverage.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2028   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         278      278           
  Lines       22761    22759    -2     
=======================================
- Hits        22752    22750    -2     
  Misses          9        9           
Impacted Files Coverage Δ
...lml/automl/automl_algorithm/iterative_algorithm.py 100.0% <ø> (ø)
evalml/tests/automl_tests/test_automl.py 100.0% <100.0%> (ø)
...lml/tests/automl_tests/test_iterative_algorithm.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfcfe68...d3594db. Read the comment docs.

@angela97lin angela97lin changed the title Fix list-valued hyperparameters in AutoMLSearch Remove lists as acceptable hyperparameter ranges in AutoMLSearch Mar 25, 2021
Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, glad the fix was fairly quick! Can you update the docs here and (maybe?)here and remove the list support/examples? Not sure if you need to remove the second one, but for sure the first

@angela97lin
Copy link
Contributor Author

@bchen1116 Thanks for pointing these out, I had no idea we had doc examples of this. Removed! 🥂

Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @angela97lin !!

@@ -283,17 +283,18 @@ def test_iterative_algorithm_stacked_ensemble_n_jobs_regression(n_jobs, linear_r
assert seen_ensemble


@pytest.mark.parametrize("parameters", [1, "hello", 1.3, -1.0006, [1, 3, 4], (2, 3, 4)])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should still keep a list example so that we can verify the IterativeAlgorithm now handles them properly!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@freddyaboulton Correct me if I'm misunderstanding but the idea now is that we don't support lists so they shouldn't be handled correctly / are expected to error, right? 😅

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking about the Drop Columns case for the data check actions. We would specify the columns to drop in the pipeline_params of the IterativeAlgorithm (at least that's the impl in #1981). So we can still pass lists it's just that the IterativeAlgorithm shouldn't do anything to that list and just pass it to the pipeline in the parameters dict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't specify list-valued hyperparameters in AutoMLSearch
3 participants