One Hot Encoder: Drop one redundant feature by default for features with two categories #1993
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1936. Uses scikit-learn impl. Does not always select minority class, see #1936 (comment) as to why this is challenging :'(
I also have my branch
1936_ohe
where I was testing out impl for minority class before hitting the error if anyone is curious.Useful for parameters defaults: #830
If drop == 'is_binary' and 'handle_unknown' == 'ignore', scikit-learn raises an error.