Revert "Allow pipelines from AutoMLSearch to be pickled (#1721)" #1958
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1958 +/- ##
=========================================
- Coverage 100.0% 100.0% -0.0%
=========================================
Files 269 268 -1
Lines 22188 22076 -112
=========================================
- Hits 22182 22070 -112
Misses 6 6
Continue to review full report at Codecov.
|
| @@ -47,7 +47,7 @@ | |||
| "source": [ | |||
| "__Note:__ To provide data to EvalML, it is recommended that you create a `DataTable` object using [the Woodwork project](https://woodwork.alteryx.com/en/stable/).\n", | |||
| "\n", | |||
| "EvalML also accepts ``pandas`` input, and will run type inference on top of the input ``pandas`` data. If you’d like to change the types inferred by EvalML, you can use the `infer_feature_types` utility method as follows. The `infer_feature_types` utility method takes pandas or numpy input and converts it to a Woodwork data structure. It takes in a `feature_types` parameter which can be used to specify what types specific columns should be. In the example below, we specify that the provider, which would have otherwise been inferred as a column with natural language, is a categorical column." | |||
| "EvalML also accepts ``pandas`` input, and will run type inference on top of the input ``pandas`` data. If you\u2019d like to change the types inferred by EvalML, you can use the `infer_feature_types` utility method as follows. The `infer_feature_types` utility method takes pandas or numpy input and converts it to a Woodwork data structure. It takes in a `feature_types` parameter which can be used to specify what types specific columns should be. In the example below, we specify that the provider, which would have otherwise been inferred as a column with natural language, is a categorical column." | |||
There was a problem hiding this comment.
Weird replacement here done by git but it looks fine: https://feature-labs-inc-evalml--1958.com.readthedocs.build/en/1958/user_guide/automl.html#AutoML-in-EvalML
There was a problem hiding this comment.
I've been seeing it come up in other PRs as well. I don't know what's up but agree it doesn't look like a problem.
There was a problem hiding this comment.
Same, looks fine though.
There was a problem hiding this comment.
That's so weird. This is the unicode character "right single quotation mark" 😆 perhaps jupyter changed the way they represent unicode somehow.
jeremyliweishih
requested review from
bchen1116,
dsherry,
freddyaboulton,
angela97lin,
chukarsten and
ParthivNaresh
⛩️ !
There was a problem hiding this comment.
@jeremyliweishih Looks good to me! Thanks for doing this. I think adding some coverage is worth it but not blocking merge.
| "outputs": [], | ||
| "source": [ | ||
| "# saving the best pipeline using .save()\n", | ||
| "# best_pipeline.save(\"file_path_here\")\n", |
There was a problem hiding this comment.
.save should still work right? Maybe we should add back this code snippet, but I agree we should delete pickle.dumps.
There was a problem hiding this comment.
Agreed, save still works because it uses cloudpickle, not pickle
There was a problem hiding this comment.
Looking good! I didn't have any comments but I agree with @freddyaboulton 's comments about the tests and the automl user guide. We should address the test comments at least before merge.
Fixes #1912.