Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Objectives to take in list inputs #1663

Merged
merged 11 commits into from Jan 11, 2021
Merged

Allow Objectives to take in list inputs #1663

merged 11 commits into from Jan 11, 2021

Conversation

bchen1116
Copy link
Contributor

fix #1456

Checks to make sure that objectives/automl/pipelines/components can all take in list/np/pd/ww inputs

@bchen1116 bchen1116 self-assigned this Jan 7, 2021
@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #1663 (f4907d3) into main (3fc3497) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #1663     +/-   ##
=========================================
+ Coverage   100.0%   100.0%   +0.1%     
=========================================
  Files         240      240             
  Lines       18523    18577     +54     
=========================================
+ Hits        18515    18569     +54     
  Misses          8        8             
Impacted Files Coverage Δ
evalml/pipelines/components/component_base.py 100.0% <ø> (ø)
evalml/objectives/objective_base.py 100.0% <100.0%> (ø)
...ents/estimators/classifiers/lightgbm_classifier.py 100.0% <100.0%> (ø)
...l/pipelines/components/transformers/transformer.py 100.0% <100.0%> (ø)
evalml/tests/automl_tests/test_automl.py 100.0% <100.0%> (ø)
evalml/tests/component_tests/test_components.py 100.0% <100.0%> (ø)
evalml/tests/component_tests/test_estimators.py 100.0% <100.0%> (ø)
evalml/tests/conftest.py 100.0% <100.0%> (ø)
...alml/tests/objective_tests/test_fraud_detection.py 100.0% <100.0%> (ø)
evalml/tests/pipeline_tests/test_pipelines.py 100.0% <100.0%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fc3497...f4907d3. Read the comment docs.

@bchen1116 bchen1116 marked this pull request as ready for review January 8, 2021 18:02
@bchen1116 bchen1116 requested review from dsherry, freddyaboulton, angela97lin, chukarsten, jeremyliweishih, ParthivNaresh and a team and removed request for dsherry, freddyaboulton and a team January 8, 2021 18:02
Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, just a possible change with respect to the generation of the different representations of input/target data.

evalml/tests/component_tests/test_components.py Outdated Show resolved Hide resolved
Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bchen1116 looks great!

Copy link
Contributor

@ParthivNaresh ParthivNaresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just had a comment on whether there should be some test coverage for Estimator's predict and predict_proba

evalml/objectives/objective_base.py Show resolved Hide resolved
@bchen1116 bchen1116 merged commit 2115144 into main Jan 11, 2021
@bchen1116 bchen1116 mentioned this pull request Jan 26, 2021
@freddyaboulton freddyaboulton deleted the bc_1456_list branch May 13, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify input support for lists in objectives/components/pipelines/automl
5 participants