New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Objectives to take in list inputs #1663
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1663 +/- ##
=========================================
+ Coverage 100.0% 100.0% +0.1%
=========================================
Files 240 240
Lines 18523 18577 +54
=========================================
+ Hits 18515 18569 +54
Misses 8 8
Continue to review full report at Codecov.
|
evalml/pipelines/components/estimators/classifiers/lightgbm_classifier.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, just a possible change with respect to the generation of the different representations of input/target data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bchen1116 looks great!
evalml/pipelines/components/estimators/classifiers/lightgbm_classifier.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just had a comment on whether there should be some test coverage for Estimator's predict
and predict_proba
fix #1456
Checks to make sure that objectives/automl/pipelines/components can all take in
list/np/pd/ww
inputs