Add missing requires and drop use of cl functions #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Chris. Actually, the elisp file is tangled from the Org file, so the fixes need to go in it. I'll copy them over. Thanks for letting me know about these. |
alphapapa
force-pushed
the
master
branch
3 times, most recently
from
61bf95c
to
159997c
Compare
alphapapa
force-pushed
the
master
branch
4 times, most recently
from
e7f0478
to
77fb6f4
Compare
alphapapa
force-pushed
the
master
branch
2 times, most recently
from
7f388b5
to
a8a6dd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed these issues when I byte compiled this file in anticipation of running one of the benchmarks you published.
called-interactively-pis actually a pretty weird function. Its argument is technically optional which is why that call still works. However, the argument being optional is obsolete (viadeclare) as of Emacs 23.1, so the byte compiler warns about it as if it was required.