Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filtering for sending messages by issue tracker and status #105

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Anuovec
Copy link

@Anuovec Anuovec commented Mar 1, 2023

Added ability to send message only for specified trackers or statuses.
E.g. I want to see, if there is a reported bug (tracker: bug, status: new) and if someone took it (status: in progress), but i do not need to know, that it done.

Similar to #99, but I changed the text field to multi-select, as you pointed out and added trackers.
Also, this resolves #96

@Anuovec Anuovec force-pushed the filter-by-trackers-statuses branch 2 times, most recently from 5ff7e79 to 5d463c4 Compare March 5, 2023 19:49
@alexandermeindl
Copy link
Collaborator

Hi @Anuovec,

I'll accept your PR. Can you fix Rails version for migration to 6.1. Use use ActiveRecord::Migration[4.2] in your PR.

@Anuovec Anuovec force-pushed the filter-by-trackers-statuses branch from 5d463c4 to c802d8e Compare March 6, 2023 18:08
@Anuovec
Copy link
Author

Anuovec commented Mar 6, 2023

Yup, no problem. Done.

@Anuovec Anuovec force-pushed the filter-by-trackers-statuses branch from c802d8e to 17708c0 Compare April 14, 2023 10:03
@Anuovec
Copy link
Author

Anuovec commented Apr 14, 2023

I found a bug.

In send_messenger_update, there was:
return if !filter_issue_trackers.empty? && filter_issue_trackers.exclude?(status.id)
instead of
return if !filter_issue_trackers.empty? && filter_issue_trackers.exclude?(tracker.id).

Fixed.

@Anuovec Anuovec mentioned this pull request Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add Tracker-Selection
2 participants