remove gunicorn server header from responses #2640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leohemsted
added a commit
to alphagov/notifications-admin
that referenced
this pull request
Oct 23, 2019
see alphagov/notifications-api#2640 for more information
leohemsted
added a commit
to alphagov/document-download-frontend
that referenced
this pull request
Oct 23, 2019
see alphagov/notifications-api#2640 for more information
This was referenced Oct 23, 2019
idavidmcdonald
approved these changes
Oct 23, 2019
servingUpAces
approved these changes
Oct 23, 2019
leohemsted
added a commit
to alphagov/notifications-admin
that referenced
this pull request
Oct 23, 2019
see alphagov/notifications-api#2640 for more information
All our requests identify the web server they were served with via the `server` response header. This opens us up to potential attackers who might be crawling the internet looking for specific versions with known vulnerabilities. As our dependencies are open source, this doesn't affect any targeted attacks as they can just look at our repos on github, but this theoretically will marginally improve security. Regardless, the header isn't useful [1], we're not the first people to want to get rid of it, and gunicorn are in the process of at least amending it to remove the version information [2]. This shouldn't have any impact on us, though an empty string will be passed through to debug information in event of a crash. That's fine though, as we already know what version we're running. [1] https://www.fastly.com/blog/headers-we-dont-want [2] benoitc/gunicorn#825
leohemsted
force-pushed
the
remove-gunicorn-header
branch
from
5fbaab6
to
acb5e9f
Compare
jonathaningram
added a commit
to govau/notify
that referenced
this pull request
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All our requests identify the web server they were served with via the
serverresponse header. This opens us up to potential attackers who might be crawling the internet looking for specific versions with known vulnerabilities. As our dependencies are open source, this doesn't affect any targeted attacks as they can just look at our repos on github, but this theoretically will marginally improve security.Regardless, the header isn't useful [1], we're not the first people to want to get rid of it, and gunicorn are in the process of at least amending it to remove the version information [2].
This shouldn't have any impact on us, though an empty string will be passed through to debug information in event of a crash. That's fine though, as we already know what version we're running.
[1] https://www.fastly.com/blog/headers-we-dont-want
[2] benoitc/gunicorn#825