Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easy to prototype with a component based architecture #585

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adamsilver
Copy link

@adamsilver adamsilver commented Aug 15, 2018

This PR let's users optionally organise their prototype with Nunjucks macros, Sass and JavaScript encapsulated by component (like GOV.UK Frontend).

@adamsilver
Copy link
Author

Solves #586

@hannalaakso
Copy link
Member

Hi @adamsilver

Thanks a lot for this contribution 🙌 We're going to discuss it at our dev catch up next Tuesday and come back to you after that.

@joelanman
Copy link
Contributor

@adamsilver thanks for this! It's definitely a direction we want to go in.

There are some blocking issues at the moment:

  1. We know we need to improve the documentation in the Prototype Kit/Design System around how to use macros. Our research tells us less technical users don't know what Nunjucks/macro means and how to use them.

  2. This feature specifically would need some documentation too.

  3. We want to improve error handling for macros. Currently any mistake crashes the whole kit with a message that is hard to understand.

@joelanman
Copy link
Contributor

Hi @adamsilver

We've just discussed this as a team again, and we think it would be good to move forward with this, thanks.

Could we add a guidance page that:

  • notes this is an advanced, experimental feature that might change
  • covers the basics of how use this feature

Let me know if you'd prefer us to take that on for you

@adamsilver
Copy link
Author

adamsilver commented Nov 6, 2018 via email

@joelanman
Copy link
Contributor

No worries, we can do that but it might take a while to be prioritised

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants