Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH support for greedy with dicodile #105

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

tomMoral
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2022

Codecov Report

Merging #105 (2168ff8) into master (8bd4756) will decrease coverage by 1.89%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
- Coverage   82.14%   80.25%   -1.89%     
==========================================
  Files          22       22              
  Lines        2172     2172              
==========================================
- Hits         1784     1743      -41     
- Misses        388      429      +41     

@agramfort
Copy link
Collaborator

any docstring to update or whats new entry to add?

@tomMoral
Copy link
Contributor Author

We agreed with @rprimet that we should also add in this PR an example on sample with dicodile that is faster on our cluster.

Also, the error in the test seems legit, we should make sure we investigate it @rprimet

@rprimet
Copy link
Collaborator

rprimet commented Nov 17, 2022

Yes the test error seems legit, we might also add dicodile to the test matrix (it was just found at the coverage step which feels weird...)

@rprimet
Copy link
Collaborator

rprimet commented Nov 21, 2022

looks like releasing + bumping the dicodile version fixes that

@tomMoral
Copy link
Contributor Author

Ok, so now, we need to create an example that shows we go faster :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants