ENH add data loader for camcan dataset + add event description into info #102
Conversation
CedricAllain
changed the title
alphacsc/datasets/camcan.py
Outdated
| │ └── ... | ||
| └── camcan-mne | ||
| ├── Cam-CAN_sss_cal.dat # calibration file | ||
| └── Cam-CAN_ct_sparse.fif # cross_talk file |
There was a problem hiding this comment.
this is specific to our setup at Inria
alphacsc/datasets/camcan.py
Outdated
| from alphacsc.utils.signal import split_signal | ||
|
|
||
|
|
||
| DATA_DIR = "/storage/store/data/" |
There was a problem hiding this comment.
alphacsc is meant to be used by anyone not just us at Inria
There was a problem hiding this comment.
I tried to mimic and reproduced how paths were handled in alphacsc/datasets/hcp.py
alphacsc/datasets/camcan.py
Outdated
|
|
||
|
|
||
| DATA_DIR = "/storage/store/data/" | ||
| PARTICIPANTS_FILE = join(DATA_DIR, "camcan/BIDSsep/smt/participants.tsv") |
There was a problem hiding this comment.
eventually the BIDSsep folder could be referred to as bids_root
alphacsc/datasets/mne_data.py
Outdated
| event_des = {'auditory/left': 1, 'auditory/right': 2, | ||
| 'visual/left': 3, 'visual/right': 4, | ||
| 'smiley': 5, 'buttonpress': 32} |
There was a problem hiding this comment.
this is an event_id for mne
There was a problem hiding this comment.
I updated event_id to be this dict.
Indeed, maybe it is not really appropriate. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #102 +/- ##
==========================================
+ Coverage 82.09% 82.14% +0.05%
==========================================
Files 22 22
Lines 2166 2172 +6
==========================================
+ Hits 1778 1784 +6
Misses 388 388 |
|
to me the hcp loader should not be present here or at least not using hard coded path. There is no chance this hcp code is working for anyone. |
alphacsc/datasets/camcan.py: new file, add a data loader function with default pre-processing parametersalphacsc/datasets/mne_data.py: add an event description dictionary ininfo['event_info']