CI: refactor and extend atomic tests #1772
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychocoderHPC
force-pushed
the
fix-atomics
branch
7 times, most recently
from
a5cb324
to
5e233b9
Compare
psychocoderHPC
force-pushed
the
fix-atomics
branch
8 times, most recently
from
d95dbb9
to
3e773d2
Compare
|
For an unknown reason, the OpenACC test shows access to invalid memory and HIP requires over 60 minutes to compile the atomic test. |
Merged
psychocoderHPC
commented
Aug 9, 2022
| using Op = alpaka::AtomicAdd; | ||
|
|
||
| template<typename... TArgs> | ||
| static ALPAKA_FN_ACC auto atomic(TArgs&&... args) |
There was a problem hiding this comment.
@jkelling found out that this variadic template usage is the root of the nvhpc error (invalid memory access)
|
The fix for atomics is already merged with #1773. |
psychocoderHPC
changed the title
psychocoderHPC
changed the title
fix alpaka-group#1769 - test all hierarchies which can be used for atomics - extent test cases to test for equal, smaller, larger and zero as left side operand - test calling the atomic interface `atomic*()` and `atomicOp<*>()`
Clang for HIP as problems if we have all atomic tests within one kernel and throws the compiler error: `error: stack size limit exceeded (155632) in _ZN6alpaka16uniform_cuda_hip6de`, therefore we split the tests into multiple kernel to workaround the issue.
psychocoderHPC
force-pushed
the
fix-atomics
branch
from
8f0e3eb
to
3408a7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang CUDA is exposing
atomic*_block()function signatures even if these can not be used by the selected architecture.This leads to compile issues if clang is used as CUDA compiler.
Our tests cases have not checked all combinations of atomics, therefore the second commit refactors the atomic tests and fixes #1769:
atomic*()andatomicOp<*>()error: stack size limit exceeded (155632) in _ZN6alpaka16uniform_cuda_hip6detail20uniformCudaHipKernelINS_8ApiHipRtENS_22AccGpuUniformCudaHipRtIS3_St17integral_constantImLm1EEmEES6_m16AtomicTestKernelIS7_xvEJPbxEEEvNS_3VecIT1_T2_EET3_DpT4_