test: extend ALPAKA_CHECK to show better error messages #1770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbastrakov
changed the title
sbastrakov
previously approved these changes
Jul 28, 2022
psychocoderHPC
force-pushed
the
topic-testShowBetterErrorMsg
branch
from
003f260
to
3c36501
Compare
psychocoderHPC
force-pushed
the
topic-testShowBetterErrorMsg
branch
7 times, most recently
from
aef5b7d
to
2ee4cdf
Compare
To know where a test fails the line and file can be very usefull.
psychocoderHPC
force-pushed
the
topic-testShowBetterErrorMsg
branch
2 times, most recently
from
294b1a5
to
e4c0e1b
Compare
psychocoderHPC
force-pushed
the
topic-testShowBetterErrorMsg
branch
from
91d7d21
to
78e212e
Compare
Disable printf to avoid compiler error: `error: stack size limit exceeded (181896) in _ZN6alpaka...`
psychocoderHPC
force-pushed
the
topic-testShowBetterErrorMsg
branch
from
78e212e
to
ef0dfb7
Compare
|
What is the state here? |
Comment on lines
+24
to
+25
| acc.cout << "ALPAKA_CHECK failed because '!(" << #expression << ")' in " << file << ":" << line \ | ||
| << "\n"; \ |
There was a problem hiding this comment.
Suggested change
| acc.cout << "ALPAKA_CHECK failed because '!(" << #expression << ")' in " << file << ":" << line \ | |
| << "\n"; \ | |
| acc.cout << "ALPAKA_CHECK failed because '!(" << #expression << ")' in " << __FILE__<< ":" << __LINE__\ | |
| << "\n"; \ |
You should be able to use the file and line macros directly inside the macro definition and not pass them around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To know where a test fails the line and file can be very useful.
before:
after: