x64 windows sourcehook hookmangen #175
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kenzzer
force-pushed
the
x64_sourcehook_hookmangen
branch
from
9cf0a7e
to
3b50c37
Compare
|
I believe you'll be the ones that want to look most at this, given it's pertaining to sourcehook. My goal is to have this PR merged, before I make any further changes for linux support. |
Kenzzer
commented
May 16, 2024
Comment on lines
+420
to
+424
| static bool g_logging = false; | ||
| if (g_logging) { | ||
| return; | ||
| } | ||
| g_logging = true; |
There was a problem hiding this comment.
This change exist, because I happened to be log looping to hell while debugging sourcehook.
Kenzzer
force-pushed
the
x64_sourcehook_hookmangen
branch
from
9bd32a3
to
3a5283e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add x64 dynamic hook support to SourceHook, Windows only
x64GenContextto generate SourceHook virtual stubs on x86_64GenBufferhas been moved tosh_asm.h, since it's only ever used to allocate blocks of memories where assembly is written atx64JitWriter(inheriting fromGenBuffer). It's a collection of helper functions to write x86_64 assembly bytesIGenContextin order to keep a single implementation ofCHookManagerAutoGenthat can be compiled on all architectures. Consequently,x64GenContext&GenContextinherit fromIGenContextThis is already a massive PR as it is. And I really don't want to be adding Linux support right now, but it will come shortly after rest assured.