CS2 ConVar RE

[Kenzzer]

ConVarRefAbstract and ConCommandRefAbstract, replaced by ConVar and ConCommand respectively.

It seems valve has offset'd the creation of the actual ConVar and ConCommand object to tier0 through the ICvar interface.
I've observed through some RE, that valve has trimmed down the ConVar and ConCommand classes to essentially just this :

class ConVar
{
	ConVarHandle m_Handle;
	ConVar* m_ConVar;
};

class ConCommand
{
	ConVarHandle m_Handle;
};

Everything else has been moved to a struct, which describes a command or convar. Those structs are then stored in a static vector, until ICvar interface is retrieved and ConVar_Register called.

The creation struct essentially looks like this :

struct ConVarOrConCommand_t
{
	const char* name;
	const char* desc;
	int8_t pad[];// specific convar/command data
	ConVarHandle* referenceToHandle;
};

The ptr to the handles are then filled with whatever ICvar returned.

[mixern6]

I'd like to suggest this structure if it's possible to implement it this way:
IConVar (or something with I) pure abstract, not templated. The header file doesn't contain anything but this interface with forward declaration of all the used types.
CConVarBase inherited from IConVar, not templated, with all the general data and logic.
CConVar < T > inherited from CConVarBase with only the type-specific data and logic.
Put the C* to cconvar.h/cconvar.cpp if it is acceptable by the design.

In the current version it will be hard to use IConVar without the type information.

[GAMMACASE]

To not give an impression that this was ignored, you can review the current structure if you have anything to add (Since some of your points were addressed). For the file naming, it's better to not rename something that's was like that since forever.

[Kenzzer]

Getting closer to finishing the metamod PR. I had to however rebase this, if I wanted to continue my work over there

[old-pigeon]

This MR breaks MMS in a minor way:

• https://github.com/alliedmodders/metamod-source/blob/eb4fcf21eac83ae80cecd1ba8ebf8bddda467ad6/core/ISmmPlugin.h#L428
• https://github.com/alliedmodders/metamod-source/blob/eb4fcf21eac83ae80cecd1ba8ebf8bddda467ad6/core/ISmmAPI.h#L137-L145

Because this MR removes class ConCommandBase;.

[psychonic]

This MR breaks MMS in a minor way:

* https://github.com/alliedmodders/metamod-source/blob/eb4fcf21eac83ae80cecd1ba8ebf8bddda467ad6/core/ISmmPlugin.h#L428

* https://github.com/alliedmodders/metamod-source/blob/eb4fcf21eac83ae80cecd1ba8ebf8bddda467ad6/core/ISmmAPI.h#L137-L145

Because this MR removes class ConCommandBase;.

This is known and expected. MM:S will have to be adapted to the SDK. Work on that is still in-progress.