Skip to content

Commit a0fc4a6

Browse files
authored
Fun with linters (#45)
* Update README.md to point to Github Pages * Appease natural language linter * examples/fabric_details.py - Add documentation * Update linter configs pyproject.toml: Remove isort profile=black isort.ini: Update line length to 180 (isort.ini is not being used currently, AFAIK) * update docs * Update docs docs/classes/overview.md: Fix name and link to ReadConfig * docs: read_config.py, fix filename in URL * overview.md: Fix formatting Also update .gitignore to ignore .prettierrc * prettier ignore all markdown * markdownlint: disable long like checking examples/fabric_details.py: once again fix isort maybe * isort: disable use_parentheses * Fix import * Remove linters/isort.ini, flake8.ini * Appease linters * Sigh
1 parent c4d0461 commit a0fc4a6

File tree

6 files changed

+11
-15
lines changed

6 files changed

+11
-15
lines changed

.github/linters/.markdown-lint.yml

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
---
2-
MD013:
3-
line_length: 256 # Line length 80 is far to short
4-
MD004: false # ul-style, * is allowed by material
5-
MD007: false # ul-indent, material not indenting with 2 spaces
6-
MD040: false # Allow ``` blocks with no language specified
7-
MD046: false # Disable Expected: indented; Actual: fenced
8-
2+
MD013: false # Very long lines in some of the example script output that we want to preserve
3+
MD004: false # ul-style, * is allowed by material
4+
MD007: false # ul-indent, material not indenting with 2 spaces
5+
MD040: false # Allow ``` blocks with no language specified
6+
MD046: false # Disable Expected: indented; Actual: fenced

.github/linters/flake8.ini

Lines changed: 0 additions & 2 deletions
This file was deleted.

.github/linters/isort.ini

Lines changed: 0 additions & 2 deletions
This file was deleted.

.prettierignore

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
# Ignore markdown
2-
**/*.md
1+
# Disable this POS
2+
**/*

examples/fabric_details.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,9 @@
7373
from ndfc_python.validators import FabricDetailsConfigValidator
7474

7575
# fmt: off
76-
from plugins.module_utils.common.api.v1.lan_fabric.rest.control.fabrics.fabrics import EpFabricDetails
76+
from plugins.module_utils.common.api.v1.lan_fabric.rest.control.fabrics.fabrics import (
77+
EpFabricDetails,
78+
)
7779

7880
# fmt: on
7981
from plugins.module_utils.common.response_handler import ResponseHandler

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ force_grid_wrap = 0
1414
line_length = 180
1515
multi_line_output = 3
1616
skip_glob = ["docs/*"]
17-
use_parentheses = true
17+
use_parentheses = false
1818

1919
[tool.pylint.main]
2020
disable = ["too-many-instance-attributes", "too-many-lines", "too-many-public-methods", "wrong-import-order"]

0 commit comments

Comments
 (0)