Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/alicloud_cs_managed_kubernetes: add param delete_options for delete operation; resource/alicloud_cs_kubernetes: add param delete_options for delete operation. #7241

Merged
merged 1 commit into from
May 20, 2024

Conversation

sanyangji
Copy link
Contributor

No description provided.

@sanyangji sanyangji force-pushed the support-delete-options branch 3 times, most recently from a544b90 to 8be63c1 Compare May 14, 2024 09:11
},
}),
Check: resource.ComposeTestCheckFunc(
testAccCheck(map[string]string{})),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

要在增加一个只保留一个 delete mode 的step

@@ -1931,7 +1959,7 @@ func fetchWorkerNodes(d *schema.ResourceData, meta interface{}) []map[string]int
var response *roacs.DescribeClusterNodePoolsResponse
wait := incrementalWait(3*time.Second, 3*time.Second)
err = resource.Retry(5*time.Minute, func() *resource.RetryError {
response, err = csClient.DescribeClusterNodePools(tea.String(d.Id()))
response, err = csClient.DescribeClusterNodePools(tea.String(d.Id()), &roacs.DescribeClusterNodePoolsRequest{})
if err != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

read 里面 set 的逻辑呢?

@sanyangji sanyangji force-pushed the support-delete-options branch 2 times, most recently from 5fd91c5 to d90aeb3 Compare May 17, 2024 02:07
Copy link
Collaborator

@ChenHanZhang ChenHanZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

… delete operation; resource/alicloud_cs_kubernetes: add param delete_options for delete operation.
Copy link
Collaborator

@ChenHanZhang ChenHanZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@ChenHanZhang ChenHanZhang merged commit ea62456 into aliyun:master May 20, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants