Apply theme to licenses page

[peakvalleytech]

📜 Description

Applied themeing to OSS license screens.

💚 How did you test it?

Mannual. Verified that theme is correctly applied when changing themes. Tested on all releavant devices.

📸 Screenshots / GIFs

[alisonthemonster]

Hi there! Thank you for giving this a go!

I think unfortunately it adds way too much complexity for just a color change. The existing OSS screen is very rarely used screen and the current implementation works well and is written by Google. If you can find an approach to use the current OSS screen that would be fantastic.

[peakvalleytech]

My original approach was to use the google provided library. Alas, I could not find an easy way to change the color. You'd think that google would have provided such a basic feature. But I did find a way to use the data generated by the library to write my own view.

I don't think it really adds 'complexity'. It's just an extra activity and fragments which only loads, parses, and displays the library data. Besides, the implementation is already done. It works nicely. Give it a try. Couldn't hurt to include it. It really completes the UI and theme feature.

TBH, if I were to have a theme feature I would want it to apply to every view and not just the most used. Otherwise, i would think twice before included the licenses. How about you run it on your end and so how you like it?

[peakvalleytech]

Hi there! Thank you for giving this a go!

I think unfortunately it adds way too much complexity for just a color change. The existing OSS screen is very rarely used screen and the current implementation works well and is written by Google. If you can find an approach to use the current OSS screen that would be fantastic.

Hi again. I was using your app again and landed on the licenses page again. It make me think about the theme again. I really think it would help improve the app. I really would hate to see my work go unused. Please! Could you reconsider?

I would really appreciate it. I've already helped contribute to this app and that's all i'm asking for in return.

I can try to refactor it some more if you'd like. I'm just still busy working on the iOS version of this app.