Viewer3D: Adjust bounding-box by moving faces #2385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elyasbny
requested review from
mh0g,
almarouk,
Just-Kiel,
demoulinv and
servantftechnicolor
elyasbny
force-pushed
the
Viewer3DBoundingBox
branch
from
2c7acbb
to
cfdaf37
Compare
servantftechnicolor
approved these changes
Apr 26, 2024
| @@ -541,6 +550,131 @@ Entity { | |||
| } | |||
| } | |||
|
|
|||
| // MOVE SURFACE ENTITY (surfaces on axis direction) | |||
| Entity { | |||
| id: surface1MoveEntity | |||
There was a problem hiding this comment.
Can we rename both entities ids to something more explicit ? Also, can you add a line or two explaining what is a "surface on axis direction". It may be clear in your head, but not for the next reader.
elyasbny
force-pushed
the
Viewer3DBoundingBox
branch
from
cfdaf37
to
ad00397
Compare
elyasbny
force-pushed
the
Viewer3DBoundingBox
branch
from
426558c
to
d376acc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented this feature, one can now adjust the bounding-box by clicking on an moving the points which are in the center of the surfaces.
Implementation remarks
I implemented two different entities, one for surfaces that are located in the direction of the axis, and one for the other surfaces. I did it, as it seemed to be a simple way to tackle the different behaviour of these surfaces when I wanted to move them. There is maybe a better way to do this.