[ui] Right click on text element in AttributeEditor open Copy/Paste menu #2366
+33
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbentejac
requested changes
Apr 19, 2024
Just-Kiel
force-pushed
the
dev/copyPasteAttributeEditor
branch
from
d8627e1
to
4c6cc4f
Compare
Just-Kiel
force-pushed
the
dev/copyPasteAttributeEditor
branch
from
4c6cc4f
to
e3e25e6
Compare
|
The selection of the text should work with the mouse. |
Comment on lines
+251
to
+252
| Clipboard.clear() | ||
| Clipboard.setText(attribute.value) |
There was a problem hiding this comment.
Not tested:
Suggested change
| Clipboard.clear() | |
| Clipboard.setText(attribute.value) | |
| textField.copy() |
fabiencastan
requested changes
May 20, 2024
| @@ -206,6 +206,7 @@ RowLayout { | |||
| Component { | |||
| id: textField_component | |||
| TextField { | |||
| id: textField | |||
There was a problem hiding this comment.
The problem comes from the root.forceActiveFocus() in the onAccepted event.
| } | ||
| MouseArea { | ||
| anchors.fill: parent | ||
| acceptedButtons: Qt.AllButtons |
There was a problem hiding this comment.
Suggested change
| acceptedButtons: Qt.AllButtons | |
| acceptedButtons: Qt.RightButton |
| if (mouse.button == Qt.RightButton) { | ||
| var menu = menuCopy.createObject(parameterLabel) | ||
| menu.parent = parameterLabel | ||
| menu.popup() |
There was a problem hiding this comment.
This kills the text selection, I'm not sure how to fix that.
There was a problem hiding this comment.
maybe with persistentSelection...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right click on text element in AttributeEditor open Copy/Paste menu