[core/ui] Add support for nodes with no computation #2364
Conversation
Just-Kiel
force-pushed
the
dev/nodeWithoutComputation
branch
from
706e6fe
to
6b9cf7b
Compare
cbentejac
changed the title
There was a problem hiding this comment.
Tested, works well, and the whole implementation is clean.
Tiny cosmetic changes to do, and see if we can come up with something that's less oriented than "InputNode" for the class' name.
It would also be good to add the upgrade of these nodes in the tests (https://github.com/alicevision/Meshroom/blob/develop/tests/test_compatibility.py).
| @@ -587,6 +587,13 @@ def stopProcess(self, chunk): | |||
| def processChunk(self, chunk): | |||
| raise NotImplementedError('No processChunk implementation on node: "{}"'.format(chunk.node.name)) | |||
|
|
|||
| class InputNode(Node): | |||
There was a problem hiding this comment.
Not entirely satisfied with using "InputNode" for non-computable nodes because I feel like there could be other use cases, but I unfortunately don't have a much better idea to designate them 😒
There was a problem hiding this comment.
What do you think of "ValueNode" ?
I feel like that it might better because it would not be necessarily in input.
Just-Kiel
force-pushed
the
dev/nodeWithoutComputation
branch
from
69b1e7d
to
ff4d951
Compare
When computing or submitting a graph, if nodes are not computable they do not send warning that nodes had trouble.
… node computable or not
Just-Kiel
force-pushed
the
dev/nodeWithoutComputation
branch
from
ff4d951
to
88b6dbe
Compare
Node without computation implemented with creation of InputNode class for easy description of Node.
Also changes for UI :