add try-paths plugins #902
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@haifzhu Please add an e2e test like this PR：https://github.com/alibaba/higress/pull/759/files#diff-e1bcf2918c10b3b1792f4d5bf4f8d46c92929572af2060964f566af2e45bc5da |
johnlanni
requested changes
Apr 10, 2024
| ) | ||
|
|
||
| // 默认超时时间为60s | ||
| var defaultTimeout uint32 = 60000 |
There was a problem hiding this comment.
默认60秒超时有点久，建议改成1秒，另外可以支持一下配置
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
add try-paths wasm go plugin to implement try_files function of nginx。
Ⅱ. Does this pull request fix one issue?
Fix the issue: Add support of try_files usage #840
Ⅲ. Why don't you add test cases (unit test/integration test)?
test cases be added in codes.
Ⅳ. Describe how to verify it
enable the plugin on the route, and check its retry function on envoy log.
Ⅴ. Special notes for reviews
no