Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify code with refactors #229

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

francestang1117
Copy link

Hi, I refactored some code. Hope you could check it. Thank you.

@CLAassistant
Copy link

CLAassistant commented Apr 7, 2023

CLA assistant check
All committers have signed the CLA.

@linux-china
Copy link
Collaborator

@francestang1117 是不是 RSocketEncodingFacade.getInstance();更好一些?

 - protected RSocketEncodingFacade encodingFacade = RSocketEncodingFacade.getInstance();
 + protected RSocketEncodingFacade encodingFacade = RSocketEncodingFacade.getInstance(new RSocketEncodingFacadeImpl());

@francestang1117
Copy link
Author

Hi @linux-china, 这里我修改主要是觉得有一个Cyclically-dependent Modularization的smell.

@linux-china
Copy link
Collaborator

Hi @linux-china, 这里我修改主要是觉得有一个Cyclically-dependent Modularization的smell.

好的,我看一下这个问题,看能否更好地修复一下。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants