Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(portal): fix SC2045-ShellCheck #14

Open
wants to merge 4 commits into
base: v0.2.2-dev
Choose a base branch
from

Conversation

Houlong66
Copy link

@Houlong66 Houlong66 commented Aug 17, 2022

Describe what this PR does / why we need it

fix SC2045-ShellCheck "Iterating over ls output is fragile. Use globs." in appactive-portal/baseline.sh and appactive-portal/cut.sh

Does this pull request fix one issue?

NONE

Describe how you did it

refer to https://github.com/koalaman/shellcheck/wiki/SC2045

Describe how to verify it

run "sh baseline.sh" and "sh cut.sh"

Special notes for reviews

NONE

@CLAassistant
Copy link

CLAassistant commented Aug 17, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ zhengkai6
✅ Houlong66
❌ MageekChiu
You have signed the CLA already but the status is still pending? Let us recheck it.

@Houlong66
Copy link
Author

☑️ Verified.
image

@Houlong66 Houlong66 changed the base branch from main to v0.2.2-dev August 31, 2022 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants