New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(javascript): expose sub algoliasearch
client's type
#873
Conversation
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we did it before it was published as multiple packages but it's no longer useful imo,
e.g: you can import SearchClient with @algolia/client-search
instead of { SearchClient } from 'algoliasearch'
wdyt?
Wouldn't typescript complain until you've added |
There was a bump on the open-issue for v4: algolia/algoliasearch-client-javascript#1080 (comment) |
yeah okay for this issue I get it 👌🏻 |
2a2c210
to
5a5b6fc
Compare
2ec3dc3
to
ee4d93c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should forbid you to force-push 😬
🧭 What and Why
🎟 JIRA Ticket:
Changes included:
Sub
algoliasearch
client's type are not exposed, which can be useful in complex implementations like in the Crawler. It also help to differentiate which client does what.🧪 Test
CI :D