Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(javascript): expose sub algoliasearch client's type #873

Merged
merged 1 commit into from Jul 27, 2022

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Jul 27, 2022

🧭 What and Why

🎟 JIRA Ticket:

Changes included:

Sub algoliasearch client's type are not exposed, which can be useful in complex implementations like in the Crawler. It also help to differentiate which client does what.

🧪 Test

CI :D

@shortcuts shortcuts self-assigned this Jul 27, 2022
@netlify
Copy link

netlify bot commented Jul 27, 2022

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit ee4d93c
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62e0f6f7e75529000872c42d
😎 Deploy Preview https://deploy-preview-873--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 27, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Copy link
Contributor

@bodinsamuel bodinsamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we did it before it was published as multiple packages but it's no longer useful imo,
e.g: you can import SearchClient with @algolia/client-search instead of { SearchClient } from 'algoliasearch'
wdyt?

@shortcuts
Copy link
Member Author

I think we did it before it was published as multiple packages but it's no longer useful imo, e.g: you can import SearchClient with @algolia/client-search instead of { SearchClient } from 'algoliasearch' wdyt?

Wouldn't typescript complain until you've added @algolia/client-search as a dependency if so? IIRC it was something people were complaining about

@shortcuts
Copy link
Member Author

There was a bump on the open-issue for v4: algolia/algoliasearch-client-javascript#1080 (comment)

@bodinsamuel
Copy link
Contributor

yeah okay for this issue I get it 👌🏻

Base automatically changed from fix/js-requester-override to main July 27, 2022 08:26
Copy link
Contributor

@bodinsamuel bodinsamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should forbid you to force-push 😬

@shortcuts shortcuts merged commit b7e3c64 into main Jul 27, 2022
@shortcuts shortcuts deleted the fix/js-exposed-types branch July 27, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants