issue: set no-unused-variable to false #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccoeurderoy
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR might looks weird, but it solves a typescript vs tslint issue.
There are some conflicts between
no-unused-variablerule, some other tslint rules and typescript that no one really understands.Ex :
palantir/tslint#2728
palantir/tslint#3478 (the last message of this issue should be read)
Setting this rule to false surprisingly removes this conflict.
Anyway, this rule is already checked by typescript core compiler. As it is well integrated with vs-code, there is no need to check it twice and it should be set to false. Part of the community is pushing in this direction :
palantir/tslint#1481