Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor payment confirmation #1202

Merged
merged 13 commits into from Mar 20, 2023
Merged

Refactor payment confirmation #1202

merged 13 commits into from Mar 20, 2023

Conversation

cbellone
Copy link
Member

@cbellone cbellone commented Mar 11, 2023 •
edited

Refactor payment confirmation:

  • Detach payment confirmation from reservation confirmation
  • Prevent inconsistencies when receiving payment confirmation: if there is any failing extensions (i.e. TICKET_ASSIGNED_GENERATE_METADATA or INVOICE_GENERATION) the payment confirmation must not fail
  • retry any failed attempt until reservation has been finalized
  • make sure to acquire discount tokens in the payment confirmation
  • show confirmation status on public frontend

Sponsored by eventplane

@cbellone cbellone requested a review from syjer March 11, 2023 17:02
@cbellone cbellone marked this pull request as ready for review March 19, 2023 19:24
@sonarcloud
Copy link

sonarcloud bot commented Mar 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 28 Code Smells

79.0% 79.0% Coverage
0.0% 0.0% Duplication

@cbellone cbellone merged commit fb568c3 into 2.0-M4-maintenance Mar 20, 2023
cbellone added a commit that referenced this pull request Mar 30, 2023
@cbellone
Refactor payment confirmation (#1202) - cherry-picked from fb568c3
660bffe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syjer syjer syjer approved these changes

Assignees
No one assigned
Labels
enhancement sponsored
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cbellone @syjer