Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use company_working_plan hours instead of hardcoded hours #1503

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

tm8544
Copy link

@tm8544 tm8544 commented Apr 17, 2024

Instead of using hardcoded start end end hours for working_plan_exceptions, it would be better to use company_working_plan start end and hours for that weekday. when resetting the form. Company plan is the baseline where the user is making an exception.

@tm8544 tm8544 changed the title Update working_plan_exceptions_modal.js Use company_working_plan hours instead of hardcoded hours Apr 17, 2024
@tm8544
Copy link
Author

tm8544 commented Apr 17, 2024

If the weekday in question is not in the company_working_plan, then hardcoded values 08:00 and 20:00 are used.
Otherwise company_working_plan hours are used.

7c4660a handled only the resetTimeSelection, as caba8b5 handles also editing.

When editing working plan exception, if the date changes, old exception needs to be deleted before saving on the new date, otherwise exception on the old date remains on the calendar (and editing with date dcange is like copying).
@tm8544
Copy link
Author

tm8544 commented Apr 19, 2024

Added c3ed328
When editing working plan exception, if the date changes, old exception needs to be deleted before saving on the new date, otherwise exception on the old date remains on the calendar (and editing with date change is like copying).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant